Language…
21 users online:  AmperSam, asterkafton, Dangil, DanMario24YT,  Donut, dotCoockie, drkrdnk, EvilAdmiralKivi, Fiblizo, Golden Yoshi, Guido_Keller, itsmefigs, JezJitzu, LightAligns, mmmdoggy,  patcdr, playagmes169, Scags,  Telinc1, timothy726, tOaO - Guests: 267 - Bots: 394
Users: 64,795 (2,377 active)
Latest user: mathew

AddmusicK Not Playing Credits (Fixed)

Fanatical like a Demon
Title says it all, literally take a new unmodified rom and just run it, beat Bowser or trigger the credits sequences, silence throughout the whole damn thing, yet the SFX still plays (yoshis hatching). I have no idea what's going on, also does this on sa1 rom. I've tried beta build from right now, and the last 3 versions.

EDIT: Here's the code for the fix founded by Medic.

Code
LevelEndMusicChange:
	LDA !MusicMir
	CMP !IrisOut
	BEQ Okay
	CMP !SwitchPalace	;;; bonus game fix
	BEQ Okay
	CMP !Miss		;;; sure why not
	BEQ Okay
	CMP !RescueEgg
	BEQ Okay		; Yep


Right here, add

Code
CMP !StaffRoll
BEQ Okay
Major thanks to Suika Ibuki for layout!
I'm open for music requests, just DM me on discord and we can further discuss there.
SMAS Soundtrack Status: 100% finished
YI Soundtrack Status: 100%
YI Unsampled Soundtrack Status: 100%
NSMB Soundtrack Status: 7.89%
Killer Instinct Soundtrack Status: 14.63%
SPC Thread
From our family to you, keep your pants dry, your dreams wet, and remember, hugs not drugs.
Fanatical like a Demon
I still can't find a solution to this.
Major thanks to Suika Ibuki for layout!
I'm open for music requests, just DM me on discord and we can further discuss there.
SMAS Soundtrack Status: 100% finished
YI Soundtrack Status: 100%
YI Unsampled Soundtrack Status: 100%
NSMB Soundtrack Status: 7.89%
Killer Instinct Soundtrack Status: 14.63%
SPC Thread
From our family to you, keep your pants dry, your dreams wet, and remember, hugs not drugs.
It works completely fine for me.
Well, good for you, but that is not even slightly helpful for solving the problem. While I don't generally moderate the forums, maybe don't even bother replying if you're not at least offering a suggestion.

Unfortunately, there's not much I can do to help either. The first thing I'd try is changing the credits music to something else (might require hex editing) and/or changing the music for a normal level to the credits music, which could determine if it's the actual credits sequence that's causing the issue or the music itself. From there, I guess you could try running a debugger on it, but that might be hard to pinpoint. Though...are you using custom credits music, by chance? According to Medic, there's a define for the credits music in tweaks.asm (so I guess you'd have to change that for the test anyway) that might need to be changed.

----------------

I'm working on a hack! Check it out here. Progress: 64/95 levels.
in patch.asm

Code
LevelEndMusicChange:
	LDA !MusicMir
	CMP !IrisOut
	BEQ Okay
	CMP !SwitchPalace	;;; bonus game fix
	BEQ Okay
	CMP !Miss		;;; sure why not
	BEQ Okay
	CMP !RescueEgg
	BEQ Okay		; Yep


Right here, try adding
Code
CMP !StaffRoll
BEQ Okay


(if that doesn't work then I'm not sure what's wrong. maybe it's your music files?? upload a BPS)
Fanatical like a Demon
Originally posted by Medic
in patch.asm

Code
Code that works


(if that doesn't work then I'm not sure what's wrong. maybe it's your music files?? upload a BPS)

Dude thanks a bunch that worked, was this in previous versions and taken out? If this is added, why did it work previously without it? Like exactly what does this code do to make it function? Thanks a bunch nonetheless, it works now!
Major thanks to Suika Ibuki for layout!
I'm open for music requests, just DM me on discord and we can further discuss there.
SMAS Soundtrack Status: 100% finished
YI Soundtrack Status: 100%
YI Unsampled Soundtrack Status: 100%
NSMB Soundtrack Status: 7.89%
Killer Instinct Soundtrack Status: 14.63%
SPC Thread
From our family to you, keep your pants dry, your dreams wet, and remember, hugs not drugs.
Originally posted by imamelia
Well, good for you, but that is not even slightly helpful for solving the problem. While I don't generally moderate the forums, maybe don't even bother replying if you're not at least offering a suggestion.

Except that I can't identify a problem if it's not there? I'm not sure why you're being so passive-aggressive.
If I try to use the fix, I get this:
Code
asar reported an error.  Refer to temp.log for details.

temp.log says:
Code
asm\SNES\temppatch.asm:1138: error: Unclosed if statement

temppatch.asm has no line 1138.
Please help me solve this issue. Help would be appreciated. #ab{;)}
Huzzah!
Fanatical like a Demon
Jx copy and paste this replacing your patch.asm.
Major thanks to Suika Ibuki for layout!
I'm open for music requests, just DM me on discord and we can further discuss there.
SMAS Soundtrack Status: 100% finished
YI Soundtrack Status: 100%
YI Unsampled Soundtrack Status: 100%
NSMB Soundtrack Status: 7.89%
Killer Instinct Soundtrack Status: 14.63%
SPC Thread
From our family to you, keep your pants dry, your dreams wet, and remember, hugs not drugs.
Originally posted by LadiesMan217
Jx copy and paste this replacing your patch.asm.


Thanks so much! I don't know what I was doing wrong! Thank you Medic and LadiesMan217!
Huzzah!
The code in the pastebin is no longer available, can someone repost it please, I can’t figure how to fix that problem.
Fanatical like a Demon
Originally posted by Medic
in patch.asm

Code
LevelEndMusicChange:
	LDA !MusicMir
	CMP !IrisOut
	BEQ Okay
	CMP !SwitchPalace	;;; bonus game fix
	BEQ Okay
	CMP !Miss		;;; sure why not
	BEQ Okay
	CMP !RescueEgg
	BEQ Okay		; Yep


Right here, try adding

Code
CMP !StaffRoll
BEQ Okay

Add that right afterwards.
Major thanks to Suika Ibuki for layout!
I'm open for music requests, just DM me on discord and we can further discuss there.
SMAS Soundtrack Status: 100% finished
YI Soundtrack Status: 100%
YI Unsampled Soundtrack Status: 100%
NSMB Soundtrack Status: 7.89%
Killer Instinct Soundtrack Status: 14.63%
SPC Thread
From our family to you, keep your pants dry, your dreams wet, and remember, hugs not drugs.
I don't know what to do with this code. I'm I supposed to already have some code where I'm supposed to add that?
I put it in a asm file but Asar give me an error for every single line.
Fanatical like a Demon
Originally posted by Domokun007
I don't know what to do with this code. I'm I supposed to already have some code where I'm supposed to add that?
I put it in a asm file but Asar give me an error for every single line.

Go into your amk directory, go into the asm folder, go into the SNES folder, open patch.asm (with any text editor of your choice), search for the above code, then copy what was said to add after that last line of code then save.
Major thanks to Suika Ibuki for layout!
I'm open for music requests, just DM me on discord and we can further discuss there.
SMAS Soundtrack Status: 100% finished
YI Soundtrack Status: 100%
YI Unsampled Soundtrack Status: 100%
NSMB Soundtrack Status: 7.89%
Killer Instinct Soundtrack Status: 14.63%
SPC Thread
From our family to you, keep your pants dry, your dreams wet, and remember, hugs not drugs.
Thank you!
Work Perfectly
thank you! i just fix it =)

i changed the text and it wasn't working so i went to de AMKGUI.exe and run the staff roll.txt into the rom and that was it the music was going perfectly =) (i think that when i add some music moved the that one and it was'nt in the rom ) thank to the community for everything =)