Gfx properties for all Bullet Bills: 8 bytes starting at PC 0x91C7.

Are you talking about star power, or the flashing invincibility after being hit by an enemy?

I have a couple of comments on your code. First of all, good job so far. It looks like you took care to ensure your PHA/PLAs were balanced, which is where a lot of beginners make mistakes.

1. If you are dealing with the first bank of RAM ($7E0000-$7E7FFF) you can omit the "7E". If you are dealing with the first page of RAM ($7E0000-$7E00FF) you can omit the leading "7E00"

Examples:

LDA $7E1420 (AF 20 14 7E) can be reduced to
LDA $1420 (AD 20 14)

STA $7E0071 (8F 71 00 7E) can become
STA $0071 (8D 71 00) or better yet
STA $71 (85 71)

2. The marked lines can be removed. "BEQ SetTeleport" is not needed, because if the value is #$04 the branch to "Fail" won't be taken and "SetTeleport" is the next section that will execute anyway. The last 3 lines I marked don't seem to do anything, what were you trying to accomplish with them?



3. Overall you seem to be getting the hang of it. This code should work without any problems. It's usually a good idea to say how you are inserting the code (block tool, sprite tool, manually, etc.), whether or not you're using an assembler (and which one), and the raw hex equivalent (if your code is short enough).

Your code could still be simplified. This is all you should need:



Notice I removed the code that was duplicated at the end. Unless there is a branch or a jump, control flows down to the next instruction. After "STA $71", the next instruction will execute which is "PLA".



There are two problems looking at the hex. It should end with 60, but I assume that's a typo. The real issue is that the branch instruction is incorrect. It looks like the assembler couldn't find the "fail" label. I think xkas requires labels to end with a colon, so make sure you include on like i did earlier in this post.

The hex for your code should be:
48 AD 20 14 C9 04 D0 06 A9 05 85 71 68 60 68 60
My version would be:
48 AD 20 14 C9 04 D0 04 A9 05 85 71 68 60

I'm not too familiar with the terminology that you are using. But I would say SMW uses bounding box collisions. Mario and sprites can be thought of as rectangles, and collision occurs when there is overlap. The tiles drawn on screen have nothing to do with it; you can have a 32x32 pixel enemy whose interaction area is 16x16. May I ask why you are curious about this?

Here are the main routines for interaction. I just copy/pasted these from the full disassembly

http://mikeyk730.googlepages.com/interaction_routines.txt

Two instances of the same problem.

You want:

CMP #$05 (C9 05) instead of:
CMP $05 (C5 05)
You are comparing against whatever value is in RAM $7E0005 instead of the number 5

LDA #$00 (A9 00) instead of:
LDA $00 (A5 00)
You are loading the value in RAM $7E0000 instead of the number 0