@cosmo: That problem can't exist on windows because that code is in a #ifndef _WIN32. Good catch though. It appears that someone (Alcaro?) replaced the call to gets (which someone complained about) with fgets in ~August 2018 without testing the fix, and fgets does include the terminating newline, unlike gets.
A very useful tool. But it doesn't work in Linux as expected. When run without the filename in the command line, it fails every time.
I did find a fix though, that only requires adding one line to the cpp file. Here is a patch file that I made to add this line, all you need to do is run the following before compiling the program,
Code
patch romclean.cpp romclean.patch
and that will fix the problem. I don't have a Windows machine set up right now, so I don't know if it will work there, or even if the problem exists in Windows.
It has been fixed
Good tool, I like how you can not download it and just use it in your browser. I would like the features in the .exe to be added to the browser version. Other than that, this is a useful tool and would definitely recommend it to a friend if they weren't sure if their SMW ROM was clean. - 5/5
This tool no longer compiles on Linux. It says that "gets" was not declared. Looked up the error and everything I'm finding is saying "gets" is deprecated and should never ever be used under any circumstances. I used this in the past and it worked great, but it would be great if this was fixed.
A false positive. SMWC has got guidelines to not upload viruses or any other malware. People who did it get punished pretty hard with the tool being deleted, obviously. It's also highly unlikely that a mod (deliberately) uploads a virus and Alcaro is one.
Follow Us On