Rabbit Labyrinth's button switch

SMW Blocks → Rabbit Labyrinth's button switch

This file is obsolete. The latest version is Button Switch. For other versions, check the version history.

Submission Details

Name:	Rabbit Labyrinth's button switch
Author:	ShadowMistressYuko
Added:	2019-04-03 07:45:54 PM
Version History:	View
Act As:	25,130
Includes GFX:	Yes
Description:	This pack includes On/Off and two Custom Trigger switches, as well as On/Off, one-way and conveyor blocks. Once Mario steps on a switch, the respective switch status will change and bounce Mario up. Mod note: PIXI is required to insert switch sprites.
Tags:	button button switch conveyor jump lorom one way player switch
Comments:	3 (jump to comments)
Rating:	5.0 (1 rating) No rating

Download 14.78 KiB | 49 downloads

Screenshots

View all

Comments (3)

ShadowMistressYuko Author 2019-04-04 06:52:49 AM Link

Originally posted by Blind Devil

Tested with GPS v1.4.1, SNES9x v1.57, in a normal ROM. The pack isn't SA-1 hybrid so manual conversion is required.

All resources work as intended, regardless of codes being more optimizable. It's accepted anyways.

@EternityLarva: for details on stuff that can be revised in the future if you plan on doing so, just expand the collapsed text.

Collapsed text: Show/Hide

> All 3 button switch blocks have instances of redundant RTLs which could be easily shared:

Code

Return:			;this label can be placed right above/below 'SpriteV' label
	RTL		;this can be removed
MarioAbove:
MarioCorner:
[...]
	RTL		;this can be removed
SpriteV:
	RTL

> In switch on/off blocks, there are instances of BRAs that lead to a simple return can be replaced (because RTL is one byte long while BRA is two bytes long):

Code

main:
	LDA $14AF
	BNE +
	LDA #$30
	STA $1693
	LDY #$01
	BRA ++		;can be changed to RTL to save a byte and some cycles
+
	LDA #$25
	STA $1693
	LDY #$00
++
RTL

> In conveyor/one-way blocks, there's an instance of RTL which is only reached via branching, that could be removed and have the label moved to another RTL instead (like in the first example):

Code

[...]
+
	LDA !Switch          ;\
	AND #!Trigger        ;|sprite xpos - 1 if switch is off
	BEQ sprite_subtract  ;/
	BRA sprite_add

Return:			;this label can be placed right above the RTL on 'mario_subtract', for example
	RTL		;this can be removed

[...]

mario_subtract:      ;mario xpos - 1
	LDA $94
	SEC 
	SBC #$01
	STA $94
	LDA $95
	SBC #$00
	STA $95
	RTL		;<<< you can put the Return label over this RTL
[...]

> In these same blocks, some branches are redundant because you're branching to another branch when you could do that directly (except if they go out of bounds, of course).

Code

[...]
	LDA $96              ;\if marioY > blockY
	BPL +                ;this can be changed to BPL MarioBelow
	BRA MarioAbove
+
	BRA MarioBelow		;this can be removed
[...]

> Finally, you can also save even more space by reusing codes that are similar with shared labels/branching. Not going to give an example for this one as I believe you will get what I'm talking about.

thank you

Blind Devil 2019-04-03 07:46:44 PM Link

> All 3 button switch blocks have instances of redundant RTLs which could be easily shared:

Code

Return:			;this label can be placed right above/below 'SpriteV' label
	RTL		;this can be removed
MarioAbove:
MarioCorner:
[...]
	RTL		;this can be removed
SpriteV:
	RTL

> In switch on/off blocks, there are instances of BRAs that lead to a simple return can be replaced (because RTL is one byte long while BRA is two bytes long):

Code

main:
	LDA $14AF
	BNE +
	LDA #$30
	STA $1693
	LDY #$01
	BRA ++		;can be changed to RTL to save a byte and some cycles
+
	LDA #$25
	STA $1693
	LDY #$00
++
RTL

> In conveyor/one-way blocks, there's an instance of RTL which is only reached via branching, that could be removed and have the label moved to another RTL instead (like in the first example):

Code

[...]
+
	LDA !Switch          ;\
	AND #!Trigger        ;|sprite xpos - 1 if switch is off
	BEQ sprite_subtract  ;/
	BRA sprite_add

Return:			;this label can be placed right above the RTL on 'mario_subtract', for example
	RTL		;this can be removed

[...]

mario_subtract:      ;mario xpos - 1
	LDA $94
	SEC 
	SBC #$01
	STA $94
	LDA $95
	SBC #$00
	STA $95
	RTL		;<<< you can put the Return label over this RTL
[...]

> In these same blocks, some branches are redundant because you're branching to another branch when you could do that directly (except if they go out of bounds, of course).

Code

[...]
	LDA $96              ;\if marioY > blockY
	BPL +                ;this can be changed to BPL MarioBelow
	BRA MarioAbove
+
	BRA MarioBelow		;this can be removed
[...]

jona255 2019-03-11 03:48:44 PM Link

coooooooooooooooooooll