When applying this patch I noticed that it causes several errors to the credits and end game sequence. To reproduce, follow these steps:
1. Open vanilla ROM in Lunar Magic and Save
2. Apply “HDMA 3.5.asm” patch with asar
3. Beat the game
During the credits the “iris” effect that switches the backgrounds is missing, as are all the backgrounds. In addition, during the enemy display, the names of the enemies fade in at their final locations instead of sliding in. Finally, some of the enemies such as Blargg appear in front of the black mask.
• Lunar Magic 3.10 (also happened with 2.53)
• asar 1.7.1
• Snes9x 1.56.2
Screenshots of the issues:
If this is not the correct place to report this bug please let me know, I’d be happy to move it. Also happy to help test any bug fixes if you decide to update the patch.
Tested with Asar v1.71, SNES9x v1.58, in both normal and SA-1 ROMs. I've also made a small change to prevent HDMA from being terminated before game over/time up fadeout while in levels.
This patch isn't required for insertion of HDMA effects per se, but it is recommended to fix overworld/level/game over/time up transitions that, by default, don't disable HDMA (gradients appear during moments in which the screen should be black). For advanced hackers, though, it's not very interesting, since they can manually disable HDMA through specific game modes via uberASM.
Remoderated. Tested with: SA-1 v1.32; bsnes v107.1; Asar 1.71
Didn't do any weird stuff so, it works.
Since this patch's FreeRAM area isn't meant to be changed, I made Asar detect and correct it for SA-1 by putting it in the BW-RAM area. Thanks to Stivi for checking that worked.