Instant Death on Powerup Loss v2.1

Or you can add "LDA $1497|!addr : BNE death" right after main to also check for cape and Yoshi i-frames.

If I'm not mistaken, if you have cape i-frames, you'll still be temporarily invulnerable to munchers, etc.; so you'll need insta-kill munchers if you want to get around this. (Just an FYI for anyone who might come across this.)

I can always appreciate more efficient code - I'd say this thing is in pretty good shape at this point!

Do note that, as before, getting hurt will drop the player's reserve item before killing them, effectively erasing it. This resource is geared more towards Kaizo design making this less of a concern, but be aware at any rate.

Tested with Asar 1.71, Lunar Magic 3.11, SA-1 1.32, Snes9x 1.59.2, UberASM Tool 1.4.

The ability to kill the player on powerup loss on a specific (sub)screen only is of... Rather specific utility, but the inclusion of the general version has me feeling more accommodating.

Works fine overall. The only thing I don't particularly like about the function of this code is that the player's reserve item is dropped at the same time they're killed, which seems more like a side effect than anything deliberate. On the other hand, the code in general seems more geared towards kaizo-type design, in which the item box would probably be strictly controlled anyway. Be aware, at any rate.

Small as the code is, there's still some fat that can be trimmed. If there's ever an update to this code, consider implementing the following optimizations:

Potential Optimizations: Show/Hide

Code

!sfx	= $20

main:
	LDA $71
	CMP #$01
	BNE return

death:

if !sfx != $04			; If chosen SFX is the same as default, don't store new SFX
	LDA #!sfx
	STA $1DF9|!addr
endif

	JSL $00F606|!bank

return:
	RTL

Using BNE to branch after the animation state check saves on a duplicate RTL. Using conditional formatting not only eliminates the !sfxOverwrite define entirely, but also avoids writing $09 useless bytes altogether should the user choose not to overwrite the default sound effect (and $04 less if they do).

You could also merge the two files using conditional formatting, but this is one case where having separate files might be the better choice considering the (sub)screen-specific version seems to be geared primarily toward level-type UberASM only.

I would also recommend breaking your RunOnScreen table into different lines for improved readability:

Code

RunOnScreen:

;   0   1   2   3   4   5   6   7   8   9   A   B   C   D   E   F	
db $01,$01,$00,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01	; (Sub)screen 00 - 0F
db $01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01,$01	; (Sub)screen 10 - 1F
...									;  etc.

But that's entirely a personal preference.

Tested with Asar 1.71, Lunar Magic 3.10, SA-1 1.32, Snes9x 1.59.2, UberASM Tool 1.4.

hey i keep on seeing this uberasm in kaizo hacks idk why

Tested With:
Lunar Magic 3.03
SNES9X 1.60
SA-1 1.32
UberASM 1.4

Fixed SA-1 compatibility and added screenshot. You don't need to apply |!addr to zero page adresses. The code could've used a few optimizations, but it's not necessary - it's pretty small and shouldn't affect performance. I can see this being used in hacks that don't have small status (always big).