3-UP Moon Sprite V2.0

Submission Details

Name:	3-UP Moon Sprite V2.0
Author:	TheXander
Added:	2024-01-04 01:24:37 PM
Tool:	PIXI
Type:	Standard
Dynamic:	No
Disassembly:	No
Includes GFX:	Yes
Description:	3-UP Moon Sprite V2.0: Description: A sprite that tries to mimic the 3-UP Moon Object tile from SMW, but in sprite form! It's a bit different from the existing one, it acts with new behaviours! obviously, this will works like the Object tile, but you can add/modify stuff! Features: PIXI Support/Compatibility. SA-1 Support/Compatibility. JSON Support. A documentation (Readme) file. Allow customize the sprite easily with an Extra Byte. More details are on the documentation (Readme) file! Requested by NopeContest
Tags:	block collectable lifes lorom moon sa-1 sprite
Comments:	2 (jump to comments)
Rating:	0.0 (0 ratings) No rating

Download 10.96 KiB | 162 downloads

Screenshots

Comments (2)

TheXander Author 2024-01-05 12:15:05 AM Link

Hey! Thanks for the moderation

Burning Loaf 2024-01-04 01:24:09 PM Link

Moderated with:
* PIXI 1.40
* Mesen 2.0
* Lunar Magic 3.40
* SA-1 Pack 1.40

Works Good.
I think it's worth noting that ceiling interaction is not implemented, but it's not a major issue. I'm also not sure about calling this a "V2.0" because a first version was never approved to begin with, but i'm not too against it.

That being said,
some parts of the code are odd: Show/Hide

Code

print "MAIN ",pc
	PHB
	PHK
	PLB
	JSR Main
	PLB
	LDA !moon_mode,x
	AND #!moon_mode_B
	BEQ NoWaterThings
	LDA !164A,x
	BEQ +
	BMI +
	LDA !AA,x
	DEC
	BMI ++
	LDA #$80
	++
	STA !AA,x
NoWaterThings:
	+
	RTL

Why is there code after the JSR Main? The point of a JSR Main to begin with is to organize code and have the "main" part of the code in a single place.
And why after the PLB? in this case it's pretty much fine, but if the code there ever had to use a table the bank byte would be wrong and it would cause issues.
I assume you just didn't know the purpose of the bank pushes and pulls. But hey, as long as it works i guess?

Code

	LDA $64 : STA $03
	LDA !1540,x
	BEQ NotBeingSpawned
	CMP #$36
	LDA #$E8
	BCS SetYSpd
	JSL $019138|!BankB		; process object interaction
	LDA !1528,x
	BNE NoPriorityChange
	LDA #$10 : STA $03
NoPriorityChange:
	JSR SubGFX
	LDA #$FC
SetYSpd:
	STA !AA,x
	LDA $9D
	BNE Return
	JSL $01801A|!BankB		; update y position, no gravity
Return:
	RTS

I also don't understand the purpose of the code right here, as far as i know none of the code in the sprite or the routines it calls set to !1540,x or !1528,x
Is this leftover code or am I missing something? Either way i've left it in because i don't think there's a reason to delete it.

(There's also some slip ups in the readme's text but i left that untouched as well)