Button Switch

SMW Blocks → Button Switch

Submission Details

Name:	Button Switch
Author:	ShadowMistressYuko
Added:	2024-12-24 01:30:21 AM
Version History:	View
Act As:	25
Includes GFX:	Yes
Description:	This pack includes an ON/OFF (or custom, if the address is configured) switch. Once Mario or a sprite steps on it, the switch status will change and bounce Mario up. Includes a custom sprite. --- v1.1 File weight reduction. v1.2 Compatible with SA1 also contact to sprites
Tags:	button lorom sa-1 switch
Comments:	5 (jump to comments)
Rating:	0.0 (0 ratings) No rating

Download 5.78 KiB | 337 downloads

Screenshots

Comments (5)

Showing comments from:

Erik 2024-12-24 01:28:53 AM Link

Tested with:
- GPS v1.4.4
- PIXI v1.42
- SA-1 v1.40
- Lunar Magic 3.50
- snes9x 1.62.3 and Mesen 2

I fixed an issue when placing this block in layer 2. The layer flag wasn't being transferred from the block to the sprite, so this just placed the switch back in layer 1 regardless of the layer it was originally in.
Other than that, it does what it's supposed to do. My one complaint is that sprites bouncing from it don't make the switch spawn the bouncy animation sprite, seemingly for no reason. Why?
Additionally, I feel like the sprite included would be better off as a bounce type instead of a regular sprite, and the code could be slighttly optimized. Still, it works, so...

I updated the description to reflect that this is only one block now.

Blind Devil From older version: Rabbit Labyrinth's button switch v1.1 2019-04-12 01:55:58 AM Link

Tested with GPS v1.4.1, SNES9x v1.57, in a normal ROM. The pack isn't SA-1 hybrid so manual conversion is required.

Thanks for the update! I also went ahead and made on/off and one-way blocks compatible with wall-running (db $37) as well.

ShadowMistressYuko Author From older version: Rabbit Labyrinth's button switch 2019-04-04 06:52:49 AM Link

Originally posted by Blind Devil

Tested with GPS v1.4.1, SNES9x v1.57, in a normal ROM. The pack isn't SA-1 hybrid so manual conversion is required.

All resources work as intended, regardless of codes being more optimizable. It's accepted anyways.

@EternityLarva: for details on stuff that can be revised in the future if you plan on doing so, just expand the collapsed text.

Collapsed text: Show/Hide

> All 3 button switch blocks have instances of redundant RTLs which could be easily shared:

Code

Return:			;this label can be placed right above/below 'SpriteV' label
	RTL		;this can be removed
MarioAbove:
MarioCorner:
[...]
	RTL		;this can be removed
SpriteV:
	RTL

> In switch on/off blocks, there are instances of BRAs that lead to a simple return can be replaced (because RTL is one byte long while BRA is two bytes long):

Code

main:
	LDA $14AF
	BNE +
	LDA #$30
	STA $1693
	LDY #$01
	BRA ++		;can be changed to RTL to save a byte and some cycles
+
	LDA #$25
	STA $1693
	LDY #$00
++
RTL

> In conveyor/one-way blocks, there's an instance of RTL which is only reached via branching, that could be removed and have the label moved to another RTL instead (like in the first example):

Code

[...]
+
	LDA !Switch          ;\
	AND #!Trigger        ;|sprite xpos - 1 if switch is off
	BEQ sprite_subtract  ;/
	BRA sprite_add

Return:			;this label can be placed right above the RTL on 'mario_subtract', for example
	RTL		;this can be removed

[...]

mario_subtract:      ;mario xpos - 1
	LDA $94
	SEC 
	SBC #$01
	STA $94
	LDA $95
	SBC #$00
	STA $95
	RTL		;<<< you can put the Return label over this RTL
[...]

> In these same blocks, some branches are redundant because you're branching to another branch when you could do that directly (except if they go out of bounds, of course).

Code

[...]
	LDA $96              ;\if marioY > blockY
	BPL +                ;this can be changed to BPL MarioBelow
	BRA MarioAbove
+
	BRA MarioBelow		;this can be removed
[...]

> Finally, you can also save even more space by reusing codes that are similar with shared labels/branching. Not going to give an example for this one as I believe you will get what I'm talking about.

thank you

Blind Devil From older version: Rabbit Labyrinth's button switch 2019-04-03 07:46:44 PM Link

> All 3 button switch blocks have instances of redundant RTLs which could be easily shared:

Code

Return:			;this label can be placed right above/below 'SpriteV' label
	RTL		;this can be removed
MarioAbove:
MarioCorner:
[...]
	RTL		;this can be removed
SpriteV:
	RTL

> In switch on/off blocks, there are instances of BRAs that lead to a simple return can be replaced (because RTL is one byte long while BRA is two bytes long):

Code

main:
	LDA $14AF
	BNE +
	LDA #$30
	STA $1693
	LDY #$01
	BRA ++		;can be changed to RTL to save a byte and some cycles
+
	LDA #$25
	STA $1693
	LDY #$00
++
RTL

> In conveyor/one-way blocks, there's an instance of RTL which is only reached via branching, that could be removed and have the label moved to another RTL instead (like in the first example):

Code

[...]
+
	LDA !Switch          ;\
	AND #!Trigger        ;|sprite xpos - 1 if switch is off
	BEQ sprite_subtract  ;/
	BRA sprite_add

Return:			;this label can be placed right above the RTL on 'mario_subtract', for example
	RTL		;this can be removed

[...]

mario_subtract:      ;mario xpos - 1
	LDA $94
	SEC 
	SBC #$01
	STA $94
	LDA $95
	SBC #$00
	STA $95
	RTL		;<<< you can put the Return label over this RTL
[...]

> In these same blocks, some branches are redundant because you're branching to another branch when you could do that directly (except if they go out of bounds, of course).

Code

[...]
	LDA $96              ;\if marioY > blockY
	BPL +                ;this can be changed to BPL MarioBelow
	BRA MarioAbove
+
	BRA MarioBelow		;this can be removed
[...]

jona255 From older version: Rabbit Labyrinth's button switch 2019-03-11 03:48:44 PM Link

coooooooooooooooooooll