Language…
9 users online: autisticsceptile1993, CrazyPencilDawg, DanMario24YT, howardadam1126, iamtheratio, kurtistrydiz, Rhubarb44230, Saela, TheOrangeToad - Guests: 277 - Bots: 316
Users: 64,795 (2,378 active)
Latest user: mathew

having a bit of a problem here

So, uh, I have been testing one of my SPCs on Higan with a SMW ROM (I pretty much do that with all of my ports before submitting actually), and it seems like all of the SFX of the level I'm testing it in gets replaced by the SMW bongo sample (A.K.A @12), heck, even the global songs too; here's a link to it btw (as you can see, it's the only SMW sample that's actually used in the port itself, and it's not just there for the sake of SFX; it's also labeled as a custom instrument if that's anything to go by)

honestly, I don't think I have encountered this error at all before, so this is quite a weird case; if anyone knows what's happening tho and can be able to help me on this, that would be damn appreciated #smw{:TUP:}
Layout by Mathos
Is it only that song? Try seeing if your other songs exhibit similar behavior just in case.

From my limited testing it looks like the other samples aren't being loaded except SMW @12. To verify this try replacing certain parts of your song with the SMW instruments.
I'll edit/comment later but it's actually improper sample loading. I can get it working with my AMK (modified Codec's Version) but still need to run it on a clean version.

EDIT: I ran this on AddMusicK 1.06
Check your AMK's sample directories or try absolute paths. This is a "working" spc and you can hear Mario getting hurt. EDL 05 is too high however.

Could be a bug with older versions too. As a last resort try loading in the entire #optimized and see if you still get bongos. Because my SPC and yours have the same SRC DIRs it's only logical that AMK was loading @12 into the wrong ones. Because I can't run it with your echo settings the other BRRs were not stored in ARAM except @12.
Well, apparently this problem is actually even weirder than I thought, because I tested this with all of the available AMK versions (both with a custom sample group and without it), and I found something quite intriguing: with the sample group, every AMK version inserted fine except 1.0.5, and without it it inserted fine only in the original AMK version (A.K.A 1.0.1).

Honestly, I'm not sure what happened at all, but it's definitely something worth looking into further; for now tho, I'll just release it with the sample group with a warning for people who are going to insert it
Layout by Mathos
Originally posted by Ultima
Honestly, I'm not sure what happened at all, but it's definitely something worth looking into further.


It's a sample loading problem. I don't know the best way to explain but for example the instrument @13 isn't being treated as global. To be sure is EVERY sound effect replaced with bongos?

Let's pretend this is the expected outcome. Custom instruments are declared after everything else (like SFX) unless you messed with the tables.
Code
SRC DIR 01: @00
SRC DIR 04: @15
SRC DIR 06: @04
SRC DIR 09: @12
SRC DIR 0A: @09
SRC DIR 12: @33

This is what is likely happening...


Code
SRC DIR 01: @12
SRC DIR 04: @12
SRC DIR 06: @12
SRC DIR 09: @12
SRC DIR 0A: @12
SRC DIR 12: @33

You can also check if using a custom instrument as bongos alleviates the issue. If you don't already have I've got one in this deprecated BRR folder. 127_5.brr
You can also manually declare the SMW bongos as a custom instrument. That is ignoring the ASM instrument table. Instead of doing @12, declare all the values like ADSR normally. This will of course waste ARAM.
Well, I already tried declaring them as custom instruments actually (mostly for the tunings), and it doesn't seem like changing those for different samples work either, so I'm still not sure as to how to fix this; I assume some ASM work will be needed for this to truly get fixed tho right
Layout by Mathos
ASM shouldn't be required. The problem is clear BUT why it's happening is a mystery. Personally I think it's a minor bug, a parsing issue.

For one it runs fine on Codec's AMK 1.1.0 Beta with *MY sample groups.
Secondly it compiled fine on base AMK 1.0.6 minus the ARAM issue.
Did you try adding in every other required sample as an instrument?

Code
	 @12                            ; @43 ; Open Hi Conga
	 @12                            ; @44 ; Hi Bongo
     "ctchoir.brr"                 $F8 $E0 $7F $05 $A0 ; @45
@0
@1
@2
@3
@4
...
......
@15


Looks like you updated your file but I've the old copy. It's more convenient for the user to not deal with new sample groups but if that's the only workaround go for it! #smw{:TUP:}
Well damn, that actually worked lol; the text is definitely a lot messier tho (and it also wastes quite a bit of ARAM), but it should remove the need for a sample group at least

Thanks for that btw #smw{^_^}
Layout by Mathos
Originally posted by Ultima
Well damn, that actually worked lol; the text is definitely a lot messier tho (and it also wastes quite a bit of ARAM),


But does it? Even so it couldn't be more than 75 extra bytes, that could easily be made up with fancy text optimizations.
Perhaps you can include the option for the user to choose. Default with the messier MML but add instructions for using the #optimizedV2

Glad it's solved so my work here is done!