Language…
15 users online:  Ahrion, crocodileman94, DasFueller,  Fernap, Foxy_9000_, Gamet2004, hoangng,  MarkAlarm, Maw, playagmes169, pnaha, Scags, sinseiga, Sweetdude, Tsquare07 - Guests: 260 - Bots: 259
Users: 64,795 (2,376 active)
Latest user: mathew

Taps by MegaNerd14

File Name: Taps
Submitted: by MegaNerd14
Authors: MegaNerd14
Insert Size: 0x00A6 bytes
Type: Song
Sample Usage: Many
Source: Port
Duration: 0:52
Featured: No
Description: *salutes*

SPC

The main problem I have with this one is how grating to the ears the Trumpets are. Even though the real song doesn't have vibrato, this version would benefit from it because the loop of the sample is very small and sounds dull as-is.

Aside from that, the second channel constantly amplifies the first one because of the long notes, which makes the first problem even more prominent. A way to fix this would be to slightly change the pitch of the second channel with the $EE command; $EE $0A would be my suggestion, but you can change the value until you find a sweet spot for you.

Another suggestion I wanted to make is to use a slower Attack for your ADSR to mimic the real trumpet a bit better. You could even have varying Attack speeds for the shorter notes (faster Attack) and the long ones (slower Attack) to spice things up a bit.

Lastly, as a minor note because there are many versions of Taps, your port is three semitones lower than the version I know, and the descending notes starting at 0:32 have incorrect lengths, but I'm wiling to let these two points slide if you can specify the version you're basing your port on.