Language…
12 users online: Cristian Cardoso, fanfan21, Golden Yoshi, Green Jerry, JezJitzu, Josuke Yoshikage, KoJi, Maw,  Nanako, Shomi, tOaO, yoshi9429 - Guests: 243 - Bots: 291
Users: 64,795 (2,377 active)
Latest user: mathew

Shatter block by coins by DooTCraft

File Name: Shatter block by coins
Submitted: by DooTCraft
Authors: DooTCraft
Act As: 130
Includes GFX: No
Description: As the name goes, this is a block that breaks on touch on every side after you collected the required amount of coins (50 by default).

Is a really simple block, usefull in puzzles levels. You can edit the amount of coins and the sound effect (%shatter_block())

Hope you find my frist submission useful.

Screenshots:
Tested with:
- Lunar Magic 3.31;
- GPS 1.4.3;
- SA-1 1.40;
- ZMZ 1.08.


While the block works, and I commend you on its functionality overall... I must reject it. Yes, I know you made it in Blockreator. While it is a valid tool if you want to create your blocks, you still have to conform to some rules when submitting them, mainly the fact you have to at least try to optimize your code.

The main issue is: you have the same code applied to three different offsets. So, why don't you use a common label, say, "Shatter", for them, and alter the JMPs as well? You would write the code only once. The way your block is now, not only we have redundant code, but the following could happen: say I wanted to modify the coins to shatter to 10. Now, you have three places you have to set the new value. If you forget one, well... we could have the novelty of the block checking for different amounts of coins depending on which side Mario touches it. The same problem occurs regarding the sound it emits when it shatters.

Last but not least, consider putting the sound and coin settings as defines in the top of your code (minor) and at least providing screenshots (or a gif) when submitting (really minor, but really appreciated). Alas, good luck with your next submissions.