Language…
24 users online: Alex No,  AmperSam, Anas,  Anorakun, DanMario24YT, GiraffeKiller, Golden Yoshi, Gorry, Green, Green Jerry, h.carrell, Hammerer, Heitor Porfirio, JikissGamer, MaffYuu, Maw, Metal-Yoshi94, playagmes169, Ray Hamilton, Rykon-V73, Seamus Sinclair, ShoopDaWhoop,  StayAtHomeStegosaurus, Tulip Time Scholarship Games - Guests: 301 - Bots: 522
Users: 64,795 (2,369 active)
Latest user: mathew

Item Box Special, v. 1.4 by Bene Hrethgir, Davros, imamelia

File Name: Item Box Special, v. 1.4
Submitted: by Bene Hrethgir
Authors: Bene Hrethgir, Davros, imamelia
Tool: Asar
Requires Free Space: Yes
Bug Fix: Yes
Featured: No
Description: This patch enables you to customize the item box quite a bit. Among other things, it allows you to fix the glitched graphics shown in the item box when the item is other than a mushroom, flower, star, or feather (credit to Kenny3900 for the original Item Box GFX Fix patch); it allows you to make some items drop stunned; and it allows you to put custom sprites in the item box. This is an update; I added a couple of new features. It can now spawn the P-Switch (blue and gray) and the Throw Block Sprite. It now corrects the item box powerup overwrite bug. Details are in the readme. added SA-1 support.
Screenshots:
For an update which is adds SA-1 support, this suprisingly fails at this. While most of the conversion is fine, I do have noticed that the SA-1 conversion is broken:
  • The biggest issue so far are all the $7Fxxxx conversions which fails in two points: The first one is that !ram on the SNES side should be $7E instead of $70 since that's where the SNES WRAM is mapped ($70 maps to SRAM instead) and the second issue is that you're OR'ing to an already existing bank. This fortunatelly – or unfortunatelly, depending on how you look at it – doesn't break the patch but it does mean that SA-1 conversion is broken (which also doesn't break since 40 | 7F = 7F). If you never realised this: You probably use SNES9x which, as good as it is, doesn't prevent SA-1 to access WRAM unlike BSNES.
  • ($000A) also is missing a |!db. This doesn't break here since the code is executed by SA-1 which mirrors I-RAM ($300A for the SNES) but for safety, please convert the address next time, okay?
  • Lastly, while you did convert the original sprite tables correctly, you didn't do the same thing with custom sprite tables which also have to be moved around due to more sprites. Refer to sa1defs.asm from GPS and PIXI on which addresses you have to chose.


Some other, smaller issues I noticed:
  • I don't think adding SA-1 support warrants you as an author.
  • You can use Submit Update instead of submitting an update separately. This presererves the file history.
  • You didn't update the version in the readme (still says 1.3 instead of 1.4).
  • ibstables_ordered.asm has the graphics swapped for the vine and balloon.
  • It's better to enter 24-bit (6 digit) instead of 20-bit (5 digit) addresses (while Asar decodes them fine, it still looks weird in the code).


Edit: Formatting