Banner
Views: 1,004,516,692
Time:
8 users online: chsbrgr, CircleFriendo,  Eevee, Fry, Impetus, MarioBaggins,  NopeContest, TwistC - Guests: 85 - Bots: 128 Users: 54,884 (2,025 active)
Latest: Dinkleberrg
Tip: Check this thread for a list of SMW sound effects.
Not logged in.
Ground Pound Koopa by Thiago678, mikeyk
Forum Index - Valley of Bowser - Moderation Questions - Sprites - Ground Pound Koopa by Thiago678, mikeyk
Pages: « 1 » Link
File Name: Ground Pound Koopa
Submitted: by Thiago678
Authors: Thiago678, mikeyk
Tool: PIXI
Type: Standard
Dynamic: No
Disassembly: No
Includes GFX: Yes
Description: This is the Ground Pound Koopa,converted to Pixi and SA-1.

(Tool Used,I checked if had errors but everthing worked fine.)

Credit not needed.



Credit Vitor Vitela and IceGuy for the tools.
Screenshots:
This sprite doesn't meet our standards:
  • The first issue is that you have a separate SA-1 and SNES version of the same sprite. This should be avoided as PIXI has got defines which remap WRAM addresses to their I- and BW-RAM counterparts.
  • Another issue is that you never replaced common routines like GetDrawInfo, SubOffScreen and SubHorzPos with their shared subroutine counterparts. Unless you have a good reason (e.g. a custom SubOffScreen), you should never put or leave those routines in custom sprites as it wastes space and it's easy to implement shared subroutines.
  • Most importantly, it breaks on newer PIXI if the ROM deosn't use SA-1 as you can spawn the sprite only once in the level! It's a major no-go and an instant rejection reason. The reason is that the latest PIXI versions allows you to place more sprites in the level in total (it doesn't for SA-1 as sa1convert is smart) which means the sprite loaded table needs to be relocated which breaks backwards compatibility with sprites with old SubOffScreen (such as your submission). Point 2, the lack of shared subroutines, is twofold: It isn't just for space but also for backwards compatibility as you can easily replace routines for your need.


Edit: Another point which came into my mind: Please don't put your name in the authors field unless you have a good reason! A SA-1 conversion is typically not a reason to be a co-author of a resource (especially if made by a tool and not by hand) but rather if you add new features or fix a major bug.
Pages: « 1 » Link
Forum Index - Valley of Bowser - Moderation Questions - Sprites - Ground Pound Koopa by Thiago678, mikeyk

The purpose of this site is not to distribute copyrighted material, but to honor one of our favourite games.

Copyright © 2005 - 2022 - SMW Central
Legal Information - Privacy Policy - Link To Us


Menu

Follow Us On

  • YouTube
  • Twitch
  • Twitter

Affiliates

  • Super Mario Bros. X Community
  • ROMhacking.net
  • Mario Fan Games Galaxy
  • sm64romhacks