Language…
11 users online: Batata Douce, ForthRightMC, Fozymandias, Isikoro, kurtistrydiz, LightAligns, mathew, Maw,  Saphros, simon.caio, TheOrangeToad - Guests: 272 - Bots: 349
Users: 64,795 (2,378 active)
Latest user: mathew

[Solved] Issue with smkdan's fly-sprite

I inserted the fly into my hack.

Eyerytime I (Spin-)jump on one (or slide into it) I get a 1-up.
This doesn't happen when I kill it with fire or a cape spin, though.

I haven't done any edits at all on the files, so I'm not sure... is it the sprite or another problem on my end?

By chance does your ROM use the SA-1 patch? Because I've noticed there's an address which was missed when converting the sprite to SA-1 hybrid, and it's in the part of the code that gives points/1UP when jumping on the sprite.
If that's the case try changing "ADC $1626,x" on line 333 to "ADC !1626,x".
Originally posted by KevinM
By chance does your ROM use the SA-1 patch?


Yes, that's correct.


Quote
Because I've noticed there's an address which was missed when converting the sprite to SA-1 hybrid, and it's in the part of the code that gives points/1UP when jumping on the sprite.
If that's the case try changing "ADC $1626,x" on line 333 to "ADC !1626,x".


Unfortunately this did not work - with that edit I can't even insert the sprite, because Pixi gives an error message about an "invalid number".

However, with what you said I figured it might be worth a try to run the file through the sa1-converter-tool.

It did change a hell of a lot of adresses for which I'm not sure if these changes are needed, though. The odd thing is I have another custom sprite (Bunbun) which shares a lot of the same code as the fly in the same level, and Bunbun worked fine with the old values (like 001DF9 instead of the newly changed 007DF9 for example) - but the thing is...

running the file through the sa1-converter did do the trick. I had to change the tilemap back because oddly enough the converter did change the tilemap values to some crap, but after that everything was fine.


The new values do irritate me a bit though, so I'm not sure if this was the best solution really.

I'm not sure if it's helpful or not, but this is the conversion.log that the converter created:



Originally posted by FPI
Unfortunately this did not work - with that edit I can't even insert the sprite, because Pixi gives an error message about an "invalid number".

That's odd, as !1626 should be defined inside PIXI's asm/sa1def.asm. Are you sure you changed it to an exclamation mark and not some other character?
Anyway, looking at the log, it looks like that was indeed the error, as everything else was already remapped.
Yeah, I'm stupid. #smw{-_-2}
I did insert the "!" but forgot to take out the "$". Sorry for the trouble.

It's working like it should now, that's for sure!

Thanks a lot for the help! :)

Ah I see, alright then! In the meantime I applied the fix to the submission so it shouldn't come up again, so thanks for reporting it.