Banner
Views: 943,524,676
Time:
11 users online: Angel Miranda, CircleFriendo, Final Theory, imamelia, JumpyIsAHacker, Koopster,  Meirdent, Mirann, MirrorReflect, Podgy456, syogayaki - Guests: 100 - Bots: 74 Users: 52,464 (1,987 active)
Latest: JumpyIsAHacker
Tip: If you're patching a BPS/IPS file to a ROM, make sure that your ROM is clean (unmodified) before you patch it. If it's not clean, use ROMclean to fix it.
Not logged in.
[BTSD] Disappear when hit - By New Hacker
Forum Index - Valley of Bowser - Moderation Questions - Blocks - [BTSD] Disappear when hit - By New Hacker
Pages: « 1 » Link
Name: [BTSD] Disappears when hit
Author & Submitted by: New Hacker
Description: If Mario/Luigi hits this custom block from below, it will disappear in a puff of smoke, like in Yoshi's Island.

Reason of removal:
There are a few things in your code that are just not quite right. One of which, as a matter of fact, crashes the game.
Let me sum them all up.

1.
Code
	RTS			;/ Return if no slots open


In BTSD blocks, don't use RTS to end block code. No, really, don't, because the game WILL crash. And it did.

2.
Code
        LDX $15E9


Why do we need this when we're writing block code and there is no sprite interaction involved whatsoever? This code is redundant and might as well be removed.

3.
Code
	PHP
        SEP #$20
	LDY #$03			;\ Find a free slot to display effect
FINDFREE:
	LDA $17C0,y		;|
	BEQ FOUNDONE		;|
	DEY			;|
	BPL FINDFREE		;|
	PLP


Even though you preserved the processor bits (though, why? A was 8-bit to begin with, and the SEP #$20 is all you did to the processor bits), you did not preserve the Y index.
In a sprite? No problem. But in a block, that's fatal. If you're going to use the Y index in a block, preserve it first, because at the end of the block code, Y should hold the high byte of the 'acts like' Map16 tile num.

My guess is that you borrowed the code from a sprite. Which is completely fine. But please do fine-tune it so it matches up with a block.
We don't want crashing blocks here on the site. ;)

--------------------
--------> Don't follow "Find Roy's Dignity", my hack. Because it's pretty outdated. <--------
Pages: « 1 » Link
Forum Index - Valley of Bowser - Moderation Questions - Blocks - [BTSD] Disappear when hit - By New Hacker

The purpose of this site is not to distribute copyrighted material, but to honor one of our favourite games.

Copyright © 2005 - 2021 - SMW Central
Legal Information - Privacy Policy - Link To Us


Menu

Follow Us On

  • YouTube
  • Twitch
  • Twitter

Affiliates

  • Super Mario Bros. X Community
  • ROMhacking.net
  • Mario Fan Games Galaxy
  • sm64romhacks