|File Name: ||Bone Bro |
|Submitted: ||2015-07-14 11:04:26 by Queen Samus |
|Authors: ||Queen Samus |
|Tool: ||Romi's Spritetool |
|Type: ||Standard |
|Dynamic: ||No |
|Disassembly: ||No |
|Includes GFX: ||No |
|Description: ||This is a Bone Bro which throws bones at Mario. The sprite is customizable (see the readme). Because this is my very first custom sprite, please give credit if used! |
Now this thing might work as it should, but that's not really a big surprise:
$ diff bone_bro.asm hammer_bro.asm
< ;; Bone Bro, by Queen Samus
> ;; Hammer Brother, by mikeyk
< ;; This sprites throws bones at Mario.
> ;; Description: This guy walks back and forth, throwing hammers at Mario.
< HAMMER_TILE = $82
> HAMMER_TILE = $6D
< X_OFFSET dcb $FF,$00
> X_OFFSET dcb $F6,$0A
< LABEL7 LDA #$06 ;A:0200 X:0009 Y:0007 D:0000 DB:03 S:01E8 P:envMXdiZcHC:0686 VC:104 00 FL:19452
> LABEL7 LDA #$04 ;A:0200 X:0009 Y:0007 D:0000 DB:03 S:01E8 P:envMXdiZcHC:0686 VC:104 00 FL:19452
< STA $1729,y ;A:0201 X:0009 Y:0007 D:0000 DB:03 S:01E8 P:envMXdizCHC:1256 VC:104 00 FL:19452
< LDA #$00
< STA $1DFC
> STA $1729,y ;A:0201 X:0009 Y:0007 D:0000 DB:03 S:01E8 P:envMXdizCHC:1256 VC:104 00 FL:19452
It's just mikeyk's hammer bro with a few minor edits to change which sprite is thrown. Now that's fine and all (I suppose this thing might be useful to some people, and it's not trivial to do if you don't have any ASM knowledge), but what's not fine is not even mentioning mikeyk when he's the one behind 99% of the sprite code, and taking all the credit yourself. Just a small note "Based on mikeyk's Hammer Brother" would suffice.
Additionally, there are a couple of issues with the sprite itself:
- You forgot to change the palette of the bone when the sprite is holding it, causing it the change colour when it's thrown.
- With how slow the bones move, I'd very much suggest toning down the default throwing frequency; as it is, there's barely any room between one and the next, making the sprite very annoying to deal.
(also calling the sprite "customizable" and then only describing how to change the sound effect it plays is kind of silly)