Banner
Views: 828,628,889
Time:
22 users online: chickaDEE Magazine, Darolac,  Deeke, Dominicentek, Doug Walker, G3rminho, h.carrell, Kely ferreira,  Lazy, LOLRyan2006 Mario Fan, lx5, MassPunishment, Miku, Nowieso, OhMuramatsu, pakkie, Pizzabusive, SimFan96, Thiago678,  Tob, Tony.Metcalfe, Yetibucca - Guests: 91 - Bots: 73 Users: 44,390 (2,540 active)
Latest: twolefthands
Tip: Do you want to create custom blocks, but have little to no experience with ASM? Use Kipernal's Blockreator!Not logged in.
bleh
Forum Index - Valley of Bowser - Moderation Questions - bleh
Pages: « 1 »
re: https://smwc.me/1483625

first off, the major rejection reasons in this update also apply to the patch it was updating, which remains in the section. shouldn't the original be deleted too, until i fix these issues? (it might be a while i kind of hate it now)

second:
Quote
It also refuses to patch on Super-FX rom, but that's because of Asar bug - replace sfxrom with sa1rom, and it'll insert correctly.


this is kind of a weird thing. is there any other side effect of doing this that might be a problem? like, might asar try to expand the rom past 2MB if i were to use sa1rom? maybe it's fine bc freecode only uses the early banks? idk asar's five million nooks and crannies

also, is there a timeline on fixing this? like, if it will be fixed soon, it might it be better to just wait until asar isn't busted and submit then instead of submitting now with a weird workaround
Quote
first off, the major rejection reasons in this update also apply to the patch it was updating, which remains in the section. shouldn't the original be deleted too, until i fix these issues? (it might be a while i kind of hate it now)


Well, I'm not that moderator who missied sa-1 tag and didn't tested it for sa-1 compatibility. I don't think we're rejecting resources that are accepted already (unless it's related with remoderation), but we can remove sa-1 tag so nobody get confused.

Quote
this is kind of a weird thing. is there any other side effect of doing this that might be a problem? like, might asar try to expand the rom past 2MB if i were to use sa1rom? maybe it's fine bc freecode only uses the early banks? idk asar's five million nooks and crannies


I agree that it's weird that sfxrom doesn't works, but sadly asar isn't my responsibility. You can put sa1rom or lorom header, and asar'll insert the patch, but those are the only way to insert it to super-fx rom. New versions of asar didn't get proper moderation, due to lack of tool mods that aren't responsible for asar update, though afaik this issue was present in older versions of asar, meaning some moderators didn't bothered testing them with super-fx rom, which is a no-good and makes things confusing. But there's patch remoderation going on right now, so we can fix compatibility by doing weird lorom/sa1rom instead of sfxrom for now. It's not even necessary to support super-fx roms, because it's not as common as sa-1.

Quote
also, is there a timeline on fixing this? like, if it will be fixed soon, it might it be better to just wait until asar isn't busted and submit then instead of submitting now with a weird workaround


Or drop super-fx support altogether. That's entirely on you to wether you want to suppor super-fx roms or not.
I didn't mean to like, dispute the fact that my patch got moderated, or put the blame on you for the sfxrom thing or anything - I tagged it with support for these things, and that support was busted bc I assumed it was easier than it is. I really just wanted to ask these questions, but I wrote my post tired, so it came across bitchy

Honestly, if sfxrom doesn't even work, I'll probably just leave support for the SuperFX pack out of my stuff. I'd rather use the SuperFX without it anyway
Definitely the sfxrom support needs to be fixed by the asar team, otherwise we'd need to remove all Super FX patches that uses sfxrom right now.

Originally posted by Katrina
re: https://smwc.me/1483625

first off, the major rejection reasons in this update also apply to the patch it was updating, which remains in the section. shouldn't the original be deleted too, until i fix these issues? (it might be a while i kind of hate it now)


This is one thing I always had trouble when I was the ASM team leader because most of the time I ended up finding out issues that the original version had as well and my recommendation was "for updates, keep in mind only the changes made. If there's any bug present but it's because of a previously accepted submission, comment it in the approved submission instead otherwise we would need to remove both submissions [...]".

--------------------
https://www.youtube.com/watch?v=3xkRkaXPN_A
---
GitHub - Twitter - YouTube - Blog - SnesLab Discord
Not at all surprised that some problem with Asar was missed during moderation. Not even mad at the ASM team either. Properly moderating Asar of all tools must be five kinds of hell.

When going through an update and you discover issues the original had too but were missed, the threshold for going back and removing the original is pretty high. Like with hacks; I've gone back and removed an already accepted hack because of a part that forced a reset, but probably would not have done so if the issue wasn't game-breaking, even if I rejected the update for the same thing. I agree with RussianMan that the rejection reasons are not sufficient enough to remove an already accepted patch (barring a remoderation), but are sufficient enough to reject an update.

The sfxrom thing is totally not your fault though, but due to the problem with Asar, it might help if you added a disclaimer. Just keep is as-is (including sfxrom) and say something like "SuperFX Users: At the time of submission, Asar does not properly support the sfxrom header. If you're using SuperFX, you can replace sfxrom with sa1rom or lorom and it will patch. However, this may have unintended consequences. Use at your own risk." Then make whatever other changes the rejection log asked for. I don't think this is a rejection reason, because the problem is somebody else's and there's nothing you can do about it and still properly support SuperFX.
Pages: « 1 »
Forum Index - Valley of Bowser - Moderation Questions - bleh

The purpose of this site is not to distribute copyrighted material, but to honor one of our favourite games.

Copyright © 2005 - 2020 - SMW Central
Legal Information - Privacy Policy - Link To Us


Total queries: 16

Menu

Follow Us On

  • YouTube
  • Twitch
  • Twitter

Affiliates

  • Super Mario Bros. X Community
  • ROMhacking.net
  • Mario Fan Games Galaxy