Congrats on finishing your first port. It's a start, but there's some more work that needs to be done before we can accept it.
First, this port has some incorrect notes, the most obvious being the section starting around 0:28.
Second, there's some unnecessary rests at the beginning of each channel; I'd suggest removing these.
Third, instrumentation could be better.
-I'd strongly suggest using ADSR to emulate the more atmospheric feel of the original better, especially with the strings, but also to get the bell (@2) sounding better.
-Using @1 for both the strings and choir oohs in the section starting around 0:13 makes them blend together and makes the section sound empty.
-In the section starting around 0:21, I don't think @1 is the best instrument there. ADSRed @2 or @7 could sound more like the original. As well, channels #0 and #1 play the same notes at times. Not only does this awkwardly amplify the identical notes and make them stick out, but it also sounds weird when channel #1 then drops an octave for a few notes. As well, it seems inconsistent which channel has the main melody and which one has the sub melody. Channels #2 and #7 (the ones with the @0) seem to do this as well, sometimes intersecting with the notes on #0 and #1. All together, this makes the lead melody and highest note jump from instrument to instrument, which sounds awkward.
Fourth, mixing could be better. The guitar (@8) on channel #6 should be much quieter, and their volume should be fading as well. There'a other ones as well, but they may fix themselves if you fix the instrumentation and incorrect notes.
Fifth, I'd suggest experimenting with echo and panning. These can help make your port sound fuller.
Finally, there's some optimization that could be better.
-Any prolonged rests should be expressed as loops of [r2] instead of [r1] or [r2.]
-There's some areas you could use label loops for. Lines 125 and 129 are the same loop, you could just use label loops to recall the loop and save space instead of redifining.
-Very short loops like [d+f+]2 often end up taking up more space than simply fully writing out the notes. An approximate rule is that a loop will end up taking less space if its total length is more than 2
One last thing, your .txt doesn't use the #spc tag to list information about the song. Check the AddmusicK readme for more info.
If you've got any questions about anything I said, I'd suggest checking out the AddmusicK readme and Wakana's tutorial.
bebn legg Discord Manager and SMW Music Moderator Hammer Bro
This port still has some issues, mostly in regards to instrumentation. While it's good that you used ADSR, I'm not sure the ADSR you defined works well. The most notable example is the @7. I'm assuming you tried replicating the "organ" from the now-old ADSR thread. However, if you look closely, it says that that ADSR should be used with the $F4 $01 hex command, which your port lacks, which, partially because of the fade out speed being 0, ends up making it sound like a rigid steel drum instead of an organ.
The mixing could use some more work as well, especially because of the new instruments, for example, the ADSRed @4 easily drowns out the @7 starting around 0:31, making the background melody stand out more, though this section feels very cluttered overall.
As well, there are some issues that persist from the first incarnation of this port as well.
-The @8 guitar at the beginning on channel #6 still doesn't fade out like the original.
-The main melody shifts from channel to channel starting around 0:31, and because of the new mixing and instruments, easily drowns out. The whole section sounds really messy in general.
One last note about optimization, while I did say that prolonged rests are better off as looped r2, shorter ones like [r2]3 are actually more efficient if you just write them out completely (e.g. r1.).
Finally, I'd suggest you maybe try porting simpler songs first, like NES or GameBoy songs, to better get a grasp of mixing and instrumentation, and how to allocate your channels so the melody doesn't jump around. After that, try experimenting with echo and panning to give your ports a fuller sound.