While I don't know of any patterns to detect faulty addmusics and I also don't have the time to go through every single hack which is suspected to have bad music, I'm pretty sure that no SMW hacks depend on being able to read the echo buffer. Thus, it's relatively safe to just enable the workaround for all SMW hacks. It's possible to grab a list of pretty much all SMW hacks ever released from Zandro's hack database
. There's ~23000 entries there currently, so storing the SHA1 hashes of each of them is going to take ~460KB in the binary (or, with names, 2.4MB uncompressed). If you insist on using SHA256 instead of SHA1, you'll have to either download the BPS of every hack in the DB or contact Zandro directly, as he hasn't published them anywhere. (The SHA1 hashes, on the other hand, can be scraped from the index list of each "section", because the hack links themselves contain the SHA1 hash of the ROM.)
Originally posted by Super Maks 64
I also have a question, how exactly would you even determine whether the Addmusic checks should be ran by BSNES?
Probably just unconditionally run them when a ROM is loaded.